Golang x/tools/gopls: ChangeSignature: OOB panic in inline.updateCalleeParams (mismatched syntactic/semantic params)

#!stacks
"goPanicIndex" && "updateCalleeParams.func1"

Issue created by stacks.

func updateCalleeParams(calleeDecl *ast.FuncDecl, params []*parameter) {
...
    filterParams := func(field *ast.Field) {
...
            for _, id := range field.Names {
                if pinfo := params[paramIdx]; pinfo != nil { <--- panic

(Similar to https://github.com/golang/go/issues/73912, but a distinct crash.)

This stack uzSaXQ was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• runtime.goPanicIndex:+2
• golang.org/x/tools/internal/refactor/inline.updateCalleeParams.func1:=2202
• golang.org/x/tools/internal/refactor/inline.updateCalleeParams:+54
• golang.org/x/tools/internal/refactor/inline.(*state).inlineCall:+428
• golang.org/x/tools/internal/refactor/inline.(*state).inline:+17
• golang.org/x/tools/internal/refactor/inline.Inline:+13
• golang.org/x/tools/gopls/internal/golang.inlineAllCalls:+171
• golang.org/x/tools/gopls/internal/golang.rewriteCalls:+118
• golang.org/x/tools/gopls/internal/golang.ChangeSignature:+142
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ChangeSignature.func1:+15
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+81
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ChangeSignature:+2
• golang.org/x/tools/gopls/internal/protocol/command.Dispatch:+45
• golang.org/x/tools/gopls/internal/server.(*server).ResolveCodeAction:+21
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+46

golang.org/x/tools/gopls@v0.18.1 go1.24.3 darwin/arm64 other,vscode (1)

Dups: Hhf1Nw

Comment From: gopherbot

Change https://go.dev/cl/684695 mentions this issue: gopls/internal/golang: recover failed inlineAllCalls

Comment From: adonovan

This stack Hhf1Nw was reported by telemetry:

• crash/crash
• runtime.gopanic:+69,+0x153
• runtime.goPanicIndex:+2,+0x73
• golang.org/x/tools/internal/refactor/inline.updateCalleeParams.func1:=2281,+0x537
• golang.org/x/tools/internal/refactor/inline.updateCalleeParams:+54,+0x178
• golang.org/x/tools/internal/refactor/inline.(*state).inlineCall:+223,+0xf73
• golang.org/x/tools/internal/refactor/inline.(*state).inline:+17,+0x1e7
• golang.org/x/tools/internal/refactor/inline.Inline:+13,+0x9b
• golang.org/x/tools/gopls/internal/golang.inlineAllCalls:+171,+0xf3b
• golang.org/x/tools/gopls/internal/golang.rewriteCalls:+118,+0x92f
• golang.org/x/tools/gopls/internal/golang.ChangeSignature:+142,+0xc63
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ChangeSignature.func1:+15,+0x16b
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3,+0x7f
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+81,+0x46b
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ChangeSignature:+2,+0x167
• golang.org/x/tools/gopls/internal/protocol/command.Dispatch:+45,+0x1dcb
• golang.org/x/tools/gopls/internal/server.(*server).ResolveCodeAction:+21,+0x17f
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+46,+0xb03

golang.org/x/tools/gopls@v0.19.1 go1.24.4 darwin/arm64 other,vscode (1)