Bug description
Hi! Since version 3.1.1 import of annotation layers of all types except AnnotationType.FORMULA stopped working.
The import has a filter_chart_annotations stub which filters out all annotation types except FORMULA.
Also if charts are used as annotation layers they are not included in the export.
Screenshots/recordings
No response
Superset version
4.1.1
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist
- [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Comment From: dosubot[bot]
Annotation layers, except for AnnotationType.FORMULA
, are not being imported or exported in Superset version 4.1.1 because the filter_chart_annotations
function explicitly filters out all annotation layers that are not of type FORMULA
. This behavior was introduced in version 3.1.1 as a temporary measure, as indicated by a TODO comment in the code suggesting the need to handle annotation dependencies on other charts or annotation layer objects [1][2].
To continue talking to Dosu, mention @dosu.
Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other
Comment From: rusackas
Honeslty, not sure if anyone's really on the case for this. PRs/investigation more than welcomed, but this is not prioritzed. Annotation Layers are one of those due-for-a-revamp backlog items.