CL 679675 seems to have added some non-portable dependencies which break the x_benchmarks repo builders on plan9 and js/wasm.
On builder x_benchmarks-gotip-plan9-arm for example, we have:
FAIL golang.org/x/benchmarks/sweet/cmd/sweet [build failed]
# go.chromium.org/luci/cipd/client/cipd/fs
../gopath/pkg/mod/go.chromium.org/luci@v0.0.0-20250606083430-318ed8f4881d/cipd/client/cipd/fs/errs.go:44:15: undefined: syscall.Errno
../gopath/pkg/mod/go.chromium.org/luci@v0.0.0-20250606083430-318ed8f4881d/cipd/client/cipd/fs/fs_posix.go:34:24: undefined: syscall.ENOTEMPTY
ok golang.org/x/benchmarks/sweet/common 0.872s
# github.com/danjacques/gofslock/fslock
../gopath/pkg/mod/github.com/danjacques/gofslock@v0.0.0-20240212154529-d899e02bfe22/fslock/lock_unix.go:63:29: undefined: syscall.Stat_t
../gopath/pkg/mod/github.com/danjacques/gofslock@v0.0.0-20240212154529-d899e02bfe22/fslock/lock_unix.go:96:12: undefined: flockLock
../gopath/pkg/mod/github.com/danjacques/gofslock@v0.0.0-20240212154529-d899e02bfe22/fslock/lock_unix.go:157:42: undefined: syscall.SYS_FCNTL
../gopath/pkg/mod/github.com/danjacques/gofslock@v0.0.0-20240212154529-d899e02bfe22/fslock/lock_unix.go:157:80: undefined: syscall.F_SETFD
../gopath/pkg/mod/github.com/danjacques/gofslock@v0.0.0-20240212154529-d899e02bfe22/fslock/lock_unix.go:157:108: undefined: syscall.Errno
# go.chromium.org/luci/common/system/unixsock
../gopath/pkg/mod/go.chromium.org/luci@v0.0.0-20250606083430-318ed8f4881d/common/system/unixsock/unixsock.go:62:24: undefined: syscall.RawSockaddrUnix
and on builder x_benchmarks-gotip-js-wasm we have
FAIL golang.org/x/benchmarks/sweet/cmd/sweet [build failed]
# github.com/danjacques/gofslock/fslock
../gopath/pkg/mod/github.com/danjacques/gofslock@v0.0.0-20240212154529-d899e02bfe22/fslock/lock_unix.go:96:12: undefined: flockLock
ok golang.org/x/benchmarks/sweet/common 0.220s
# go.chromium.org/luci/common/system/unixsock
../gopath/pkg/mod/go.chromium.org/luci@v0.0.0-20250606083430-318ed8f4881d/common/system/unixsock/unixsock.go:62:24: undefined: syscall.RawSockaddrUnix
Comment From: gabyhelp
Related Issues
- x/benchmarks/sweet/benchmarks/etcd: doesn't build on Plan 9 #68287 (closed)
- x/benchmarks/sweet: build broken on plan9 as of CL 368195 via github.com/blevesearch/mmap-go and go.etcd.io/bbolt #49920 (closed)
- x/benchmarks/sweet/cmd/sweet: TestSweetEndToEnd failures #70649
- x/benchmarks/sweet: go-build failed when install cmd/compile and cmd/link #72920
- x/build: build failures due to `410 Gone` responses from `symbolic-datum-552` GOPROXY #53572
- x/benchmarks/sweet: build broken on aix-ppc64 as of CL 368195 via github.com/blevesearch/mmap-go #49919 (closed)
- cmd/go: build broken on Plan 9 since CL 69830 #22219 (closed)
Related Code Changes
- all: update vendored dependencies
- cmd/vendor: vendor latest golang.org/x/mod
- all: move internal/x to vendor/golang.org/x and revendor using 'go mod vendor'
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
Comment From: mknyszek
We don't intend to run all benchmarks on all platforms. For example, we have benchmarks that absolutely cannot run outside of, say, linux/amd64 and linux/arm64, which we simply disable. I think we should also disable benchmarks (and packages) that rely on these dependencies on platforms that do not support them, such as the Sweet benchmarks.