Golang x/tools/gopls/internal/test/marker: "send on closed channel" in MCP integration

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/callhierarchy/issue64451.txt
=== PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-06-04 10:32 x_tools-gotip-linux-ppc64_power8 tools@fed8cc83 go@cfb4e9bc x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-04 16:26 x_tools-go1.24-linux-ppc64_power8 tools@1afeefa8 release-branch.go1.24@9f9cf28f x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-04 18:03 x_tools-go1.24-linux-ppc64_power8 tools@4546fbd0 release-branch.go1.24@9f9cf28f x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-05 17:54 x_tools-go1.24-linux-ppc64_power8 tools@f114dcf9 release-branch.go1.24@6796ebb2 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-10 14:43 x_tools-go1.23-linux-ppc64le_power10 tools@5e002652 release-branch.go1.23@d375ae50 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-10 16:36 x_tools-go1.23-linux-ppc64le_power10 tools@80d35705 release-branch.go1.23@d375ae50 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-10 22:15 x_tools-go1.24-linux-ppc64_power8 tools@439ea2f0 release-branch.go1.24@7d08a16f x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 15:46 x_tools-go1.23-linux-ppc64le_power9 tools@cc2d9543 release-branch.go1.23@3eedbde2 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 15:48 x_tools-go1.24-linux-ppc64_power8 tools@d9ea5272 release-branch.go1.24@7d08a16f x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 16:25 x_tools-go1.25-linux-ppc64_power8 tools@03b26e7d release-branch.go1.25@8ac5714e x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 16:25 x_tools-go1.24-linux-ppc64_power8 tools@3f93fece release-branch.go1.24@7d08a16f x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 16:25 x_tools-go1.25-linux-ppc64_power8 tools@3f93fece release-branch.go1.25@8ac5714e x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 18:44 x_tools-gotip-linux-ppc64_power8 tools@9b68bc99 go@96a6e147 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-06-13 19:58 x_tools-go1.25-linux-ppc64_power8 tools@5099ddaf release-branch.go1.25@8ac5714e x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-07 19:33 x_tools-go1.24-darwin-arm64-race tools@b2f3de7a release-branch.go1.24@dbf30d88 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-07-07 19:33 x_tools-gotip-darwin-arm64_15 tools@b2f3de7a go@86b5ba73 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: adonovan

This looks legit:

panic: send on closed channel

goroutine 55729 [running]:
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.func2()
    /Users/swarming/.swarming/w/ir/x/w/targetrepo495829232/gopls/internal/lsprpc/lsprpc.go:116 +0x44
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream(0x14014eabf50, {0x105dddc70, 0x14015566330}, {0x105de2648, 0x1400c22e370})
    /Users/swarming/.swarming/w/ir/x/w/targetrepo495829232/gopls/internal/lsprpc/lsprpc.go:130 +0x780
created by golang.org/x/tools/internal/jsonrpc2/servertest.(*PipeServer).Connect in goroutine 332
    /Users/swarming/.swarming/w/ir/x/w/targetrepo495829232/internal/jsonrpc2/servertest/servertest.go:84 +0x15c
FAIL    golang.org/x/tools/gopls/internal/test/marker   7.768s

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 13:34 x_tools-go1.24-darwin-amd64_12 tools@02a89fc3 release-branch.go1.24@dbf30d88 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-07-08 13:34 x_tools-go1.25-darwin-amd64_13 tools@02a89fc3 release-branch.go1.25@b062eb46 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 15:19 x_tools-go1.25-linux-amd64-boringcrypto tools@e01e5252 release-branch.go1.25@2899144b x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 13:34 x_tools-go1.24-netbsd-arm64 tools@02a89fc3 release-branch.go1.24@dbf30d88 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 15:19 x_tools-go1.23-darwin-arm64-race tools@e01e5252 release-branch.go1.23@e919b332 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 16:44 x_tools-go1.25-darwin-arm64-race tools@46b77f46 release-branch.go1.25@e73dadc7 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-07-08 18:57 x_tools-gotip-darwin-arm64-race tools@986a3c00 go@54c9d776 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 16:51 x_tools-gotip-darwin-amd64_14 tools@1a2d84c1 go@54c9d776 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-07-08 20:57 x_tools-go1.23-darwin-amd64_12 tools@7b8dc5db release-branch.go1.23@0a75dd7c x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

2025-07-08 20:57 x_tools-go1.24-darwin-amd64_12 tools@7b8dc5db release-branch.go1.24@9d828e80 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 16:51 x_tools-go1.23-darwin-amd64_14 tools@1a2d84c1 release-branch.go1.23@0a75dd7c x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/callhierarchy/issue64451.txt"

2025-07-08 17:41 x_tools-go1.25-darwin-amd64-race tools@2d4b6bf0 release-branch.go1.25@e73dadc7 x/tools/gopls/internal/test/marker.Test/callhierarchy/issue64451.txt [SKIP] (log)

=== RUN Test/callhierarchy/issue64451.txt === PAUSE Test/callhierarchy/issue64451.txt

— watchflakes

Comment From: findleyr

Fixed by https://go.dev/cl/686916: no more channels.