Screenshot
Description
On Welcome screen, a space is missing for the "+ SQL Query" button Others buttons are OK
Comment From: xavier-GitHub76
Version : Superset 4.1.1
Comment From: xavier-GitHub76
Another button (on "Saved query" screen) with missing space :
Comment From: rusackas
It looks like there is a space on the second one... not sure what you mean with that.
Comment From: rusackas
Same issue with this cached display in the Chart Editor
Comment From: mistercrunch
Doing quite a bit or refactoring around antd v5 migration, we'll likely get to those but could use some help. Should be easy to git grep -i "+SQL Query
and submit a fix.
Comment From: xavier-GitHub76
@rusackas :
It looks like there is a space on the second one... not sure what you mean with that.
There appears to be a space, but it's narrower than the other buttons. Unsure, I compared it with screenshots.
Comment From: mistercrunch
cached display in the Chart Editor
@rusackas this is fixed in the template_less
(Theming) collab branch, looking to merge into master
once 5.0 is done, and will be the basis for 5.1.x
Comment From: abhinav-1305
Hi @rusackas - is this resolved?
Comment From: mistercrunch
@abhinav-1305 you should be able to pull the 5.0.0rc4
and check whether it's there or not, but if not someone could potentially patch for 5.1 . On our side focussing on 6.0 where this and hundreds of other visual glitches are already addressed.
Comment From: xavier-GitHub76
I try with 5.0.0rc4 but space is missing
Comment From: mistercrunch
Ok, if someone wants to fix it in theory we can flag the PR to get cherried into 5.0.1 or 5.1.0, whichever comes first. Otherwise it'll be in 6.0. There will be a big push to make 6.0 look squeaky clean, most effort will be put in that direction along with all the theming-related features.
Comment From: xavier-GitHub76
I don't know if it can make a difference, but my test was conducted using the Docker image 5.0.0rc4. I just discovered GitHub's ephemeral environments (very handy) for testing the PR https://github.com/apache/superset/pull/33762
The space is correct on http://44.247.50.122:8080/
However, the image 5.0.0rc4 is more recent (Jun 18, 2025 at 7:45 pm) than the commit fb9869710dc32669e1012ccf01c62db252d54849 (Jun 12, 2025)
Comment From: msyavuz
Reopening this as the specific SQL Query button is still present after #34237
Comment From: EnxDev
I see this on the homepage
Comment From: msyavuz
Oh yeah it's fixed. I was not on master