#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
Issue created automatically to collect these failures.
Example (log):
=== RUN TestPull/2
pull_test.go:48: have 0 extra goroutines, want 1
pull_test.go:54: have 0 extra goroutines, want 1
pull_test.go:54: have 0 extra goroutines, want 1
pull_test.go:56: have 0 extra goroutines, want 1
pull_test.go:59: have -1 extra goroutines, want 0
pull_test.go:66: have -1 extra goroutines, want 0
pull_test.go:66: have -1 extra goroutines, want 0
pull_test.go:68: have -1 extra goroutines, want 0
pull_test.go:73: have -1 extra goroutines, want 0
--- FAIL: TestPull/2 (0.01s)
Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "iter:iter" && test == "TestPull/2"
2024-02-27 23:58 gotip-darwin-amd64_13 go@96e9838f iter:iter.TestPull/2 (log)
=== RUN TestPull/2 pull_test.go:48: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:56: have 0 extra goroutines, want 1 pull_test.go:59: have -1 extra goroutines, want 0 pull_test.go:66: have -1 extra goroutines, want 0 pull_test.go:66: have -1 extra goroutines, want 0 pull_test.go:68: have -1 extra goroutines, want 0 pull_test.go:73: have -1 extra goroutines, want 0 --- FAIL: TestPull/2 (0.01s)Comment From: mknyszek
I think this test might just have an issue with background goroutines getting spawned or exiting. It shouldn't happen often but I suppose it can happen (e.g. a goroutine that is presumed to exit after it unblocked on a channel actually took a long time to unblock on it, or something).
Comment From: mknyszek
CC @rsc maybe?
Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull/`
2024-03-15 03:39 gotip-darwin-amd64_13 go@453cbb8f iter:iter.TestPull/3 (log)
=== RUN TestPull/3 pull_test.go:48: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:56: have 0 extra goroutines, want 1 pull_test.go:66: have -1 extra goroutines, want 0 pull_test.go:66: have -1 extra goroutines, want 0 pull_test.go:68: have -1 extra goroutines, want 0 pull_test.go:73: have -1 extra goroutines, want 0 --- FAIL: TestPull/3 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-06 15:34 gotip-darwin-amd64_14 go@3c72dd51 iter:iter.TestPull2/0 (log)
=== RUN TestPull2/0 pull_test.go:90: have 0 extra goroutines, want 1 pull_test.go:98: have 0 extra goroutines, want 1 pull_test.go:101: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:110: have -1 extra goroutines, want 0 pull_test.go:115: have -1 extra goroutines, want 0 --- FAIL: TestPull2/0 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-07 18:36 netbsd-386-9_3 go@709d6d5d iter.TestPull2 (log)
--- FAIL: TestPull2 (0.00s) --- FAIL: TestPull2/0 (0.00s) pull_test.go:88: have 0 extra goroutines, want 1 pull_test.go:96: have 0 extra goroutines, want 1 pull_test.go:99: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:113: have -1 extra goroutines, want 0Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-07 15:21 gotip-darwin-amd64-longtest go@38ee0c76 iter.TestPull/3 (log)
=== RUN TestPull/3 pull_test.go:46: have 0 extra goroutines, want 1 pull_test.go:52: have 0 extra goroutines, want 1 pull_test.go:52: have 0 extra goroutines, want 1 pull_test.go:52: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:64: have -1 extra goroutines, want 0 pull_test.go:64: have -1 extra goroutines, want 0 pull_test.go:66: have -1 extra goroutines, want 0 pull_test.go:71: have -1 extra goroutines, want 0 --- FAIL: TestPull/3 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-08 19:10 gotip-linux-arm64-race go@69e75c85 iter.TestPull2/1 (log)
=== RUN TestPull2/1 pull_test.go:94: have 0 extra goroutines, want 1 pull_test.go:96: have 0 extra goroutines, want 1 pull_test.go:99: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:113: have -1 extra goroutines, want 0 --- FAIL: TestPull2/1 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-17 00:11 gotip-linux-amd64-race go@69105d79 iter.TestPull2/3 (log)
=== RUN TestPull2/3 pull_test.go:94: have 0 extra goroutines, want 1 pull_test.go:94: have 0 extra goroutines, want 1 pull_test.go:94: have 0 extra goroutines, want 1 pull_test.go:96: have 0 extra goroutines, want 1 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:113: have -1 extra goroutines, want 0 --- FAIL: TestPull2/3 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-15 21:51 gotip-freebsd-riscv64 go@13d36a9b iter.TestPull2/0 (log)
=== RUN TestPull2/0 pull_test.go:88: have 0 extra goroutines, want 1 pull_test.go:96: have 0 extra goroutines, want 1 pull_test.go:99: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:113: have -1 extra goroutines, want 0 --- FAIL: TestPull2/0 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-17 17:15 gotip-darwin-amd64_13 go@01ad44bc iter:iter.TestPull/2 (log)
=== RUN TestPull/2 pull_test.go:46: have 0 extra goroutines, want 1 pull_test.go:52: have 0 extra goroutines, want 1 pull_test.go:52: have 0 extra goroutines, want 1 pull_test.go:54: have 0 extra goroutines, want 1 pull_test.go:57: have -1 extra goroutines, want 0 pull_test.go:64: have -1 extra goroutines, want 0 pull_test.go:64: have -1 extra goroutines, want 0 pull_test.go:66: have -1 extra goroutines, want 0 pull_test.go:71: have -1 extra goroutines, want 0 --- FAIL: TestPull/2 (0.00s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- (pkg == "iter" || pkg == "iter:iter") && test ~ `TestPull`
2024-05-22 13:40 gotip-linux-arm64-boringcrypto go@bb2b7363 iter.TestPull2/0 (log)
=== RUN TestPull2/0 pull_test.go:88: have 0 extra goroutines, want 1 pull_test.go:96: have 0 extra goroutines, want 1 pull_test.go:99: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:106: have -1 extra goroutines, want 0 pull_test.go:108: have -1 extra goroutines, want 0 pull_test.go:113: have -1 extra goroutines, want 0 --- FAIL: TestPull2/0 (0.00s)Comment From: gopherbot
Change https://go.dev/cl/587917 mentions this issue: iter: deflake TestPull by letting exiting goroutines finish
Comment From: ianlancetaylor
This is still happening.
Comment From: ianlancetaylor
68118
68119
68120
Comment From: mknyszek
This is still happening.
I'm not sure it is. All the reported failures in https://github.com/golang/go/issues/68118, https://github.com/golang/go/issues/68119, and https://github.com/golang/go/issues/68120 are from mid-May, before this was fixed on May 24th. I don't know why watchflakes only recently opened issues for these failures, but I don't think there's anything to do here. Closing, but if I got something wrong please feel free to reopen.
Comment From: ianlancetaylor
Ah ha, sorry for the noise.