Hi,
As a member of the golang/mips, I have been contributing to golang on mips and riscv64 for some time. I'd like to apply for approver rights (+2 +1 etc..) for myself, and hope to contribute more to golang in the future.
My Gerrit account: jz531210@gmail.com (ID 61713)
https://go-review.googlesource.com/q/owner:jz531210@gmail.com
Thanks.
Comment From: gabyhelp
Related Issues
- access: requesting access for Running TryBots #67577 (closed)
- access: approvers #66611 (closed)
- access: Approver Access ("approvers") #41898 (closed)
- access: approvers #64255 (closed)
- access: Approving CLs ("approvers") #56321 (closed)
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
Comment From: HeliC829
cc @golang/mips
Comment From: dmitshur
CC @4a6f656c, @Rongronggg9, @milanknezevic, @mengzhuo Since you're also members of golang/mips and golang/riscv64, your input on this access request would be very useful. Thanks.
Comment From: Rongronggg9
I believe Zhu's instruction-set-level knowledge is sufficient for maintaining MIPS things. We are glad to see Zhu keep moving forward on this route.
We don't have many comments on Zhu's riscv64 contributions. I personally (and in private) offered some technical reviews on the rv64* asm optimizations that Zhu did for OpenSSL. I've seen Zhu's big progress during this period.
See also https://github.com/golang/go/issues/66786#issuecomment-2050872857.
Comment From: dmitshur
Hi Julian,
Thank you for contributing to the Go project, and for your work of being a maintainer of the MIPS ports. We've discussed this request on the team and agreed to grant you this access. I've added you to the approvers
group now.
Please be familiar with the rules for voting and submitting changes as described at https://go.dev/wiki/GerritAccess#approving-cls-approvers. In particular, for CLs that affect other ports rather than being MIPS-only, please be sure there another appropriate reviewer also has a chance to +2 before submitting. If you're unsure or have any questions, please don't hesitate to ask us.
Thank you again for your help.