Comment From: SivaTharun
@OlgaMaciaszek can i work on this issue.
Comment From: OlgaMaciaszek
@SivaTharun , thanks for reaching out. @maniotie is already working on this issue for now. If not all modules are converted, I will get back to you here.
Comment From: OlgaMaciaszek
@maniotie is now working on reducing method and class visibility after the conversion to JUnitJupiter.
Comment From: ThomasTopuz
Is anybody working on this?
Comment From: OlgaMaciaszek
I don't think anybody is at the moment. They are only a few test left, but possibly the ones that were proving tricky during the previous work done by contributors. Would you like to work on it @ThomasTopuz ?
Comment From: deii
The remaining tests use the deprecated ModifiedClassPathRunner
class. It would be possible to replace it with ModifiedClassPathExtension
, but this class has a package-access level. How could we solve this? Should I create an issue and patch in the spring-cloud-commons project?
https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-test-support/src/main/java/org/springframework/cloud/test/ModifiedClassPathExtension.java#L49
Comment From: OlgaMaciaszek
Right, @deii. Have created: https://github.com/spring-cloud/spring-cloud-commons/pull/1358.
Comment From: OlgaMaciaszek
It's merged now. @deii @ThomasTopuz Let me know if any of you would like to work on this.
Comment From: Pjaygit
@OlgaMaciaszek is this available to work?
Comment From: OlgaMaciaszek
Yes, @Pjaygit. Would you like to work on it?
Comment From: Pjaygit
Sure. Would like to try @OlgaMaciaszek
Comment From: OlgaMaciaszek
Sounds good, @Pjaygit. Please go ahead.
Comment From: OlgaMaciaszek
Please add your changes against the 4.1.x
branch.
Comment From: david-vana
Looks like nobody is working on this currently. Could you please check my PR #4421 @OlgaMaciaszek ?
Comment From: OlgaMaciaszek
Thanks, @david-vana - will review this week.
Comment From: david-vana
@OlgaMaciaszek My PR is agains 4.2.x but as I realized - it should be earliest maintained branch 4.1.x, right? Should I create new PR agains 4.1.x?
Comment From: OlgaMaciaszek
@david-vana Yes, please.
Comment From: david-vana
New PR #4425 against 4.1.x ready for review.
Comment From: Shaanworkspace
I'd like to work on this, is it available?