This is a reminder issue to re-vendor x/telemetry with bug-fixes prior to go1.23rc1.
We are effectively treating x/telemetry as frozen for the moment, and want to make sure any bugfixes are included in the Go release.
Comment From: dmitshur
Note that #36905 tracks re-vendoring all dependencies in the main Go repo, which will happen soon now that we're in the freeze. This issue can be kept open after that happens if there are more x/telemetry-specific changes to bring in afterwards.
Comment From: dmitshur
FYI CL 589935 updated x/telemetry to v0.0.0-20240603224550-f2b69109f79b. Feel free to close this if that's enough for the needs of RC 1, or keep it open if you'd like to check in again, closer to RC 1 target date, in case more bug-fixes land in x/telemetry by then.
Comment From: findleyr
Thanks. I plan to revendor again on Friday, and close this issue at that time.
Comment From: findleyr
We still have a couple fixes pending, notably https://go.dev/cl/592017, which we want to land before revendoring.
Comment From: dr2chase
This is marked as a release blocker, is open, is not marked okay-after-RC1, and the scheduled cut for 1.23RC1 is roughly 24 hours from now. Where do we stand on this?
Comment From: findleyr
I think we're good now. It looks like Michael re-vendored in https://go.dev/cl/592255.
I'm going to move this to ok-after-rc1. I suspect we may have additional bug fixes after the RC.
Comment From: gopherbot
Change https://go.dev/cl/594021 mentions this issue: [release-branch.go1.23] cmd: vendor golang.org/x/telemetry@a740542
Comment From: gopherbot
Change https://go.dev/cl/594019 mentions this issue: [release-branch.go1.23] cmd/vendor: pull in golang.org/x/telemetry@b4de734
Comment From: joedian
@findleyr I see the last cl on this was abandoned. Is this issue resolved now?
Comment From: findleyr
Not resolved. The last CL was abandoned because it will instead be performed by the release team as part of the backporting process.
Comment in https://github.com/golang/go/issues/67617#issuecomment-2173806587 still applies: as a matter of process, I want to ensure we have the correct telemetry code prior to the final release.
Comment From: gopherbot
Change https://go.dev/cl/597896 mentions this issue: cmd: vendor golang.org/x/telemetry@268b4a8ec2d7