Bug description
Looking at 5.0.0 images these have increased in size compare to 4.1.x 892MB vs 292MB This seems to stem from the fact that this change #31385 moved playwright, gecko, chromium from the dev image into the base image which is then used for everything downstream.
Screenshots/recordings
No response
Superset version
5.0.0
Python version
3.10
Node version
Not applicable
Browser
Not applicable
Additional context
No response
Checklist
- [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Comment From: agologan
@mistercrunch in the subsequent change #31386 INCLUDE_CHROMIUM
was disabled for most dev workflows.
Should've this been disabled for tag-release#L95 workflow as well?
Or am I misunderstanding the purpose of playwright?
Comment From: dosubot[bot]
Hi @agologan! I'm Dosu and I’m helping the superset team.
You’re not misunderstanding—Playwright is mainly for browser-based testing and automation, which does require Chromium or similar browsers. In the release workflow (tag-release.yml), neither Playwright nor Chromium is enabled or required by default. The relevant build args and environment variables (like INCLUDE_CHROMIUM) are set to false unless explicitly overridden, and the workflow itself doesn’t run browser-based tests or tasks that would need these dependencies. So, there’s no need to explicitly disable INCLUDE_CHROMIUM in the release workflow—it’s already off by default, and the release images shouldn’t include Chromium or Playwright unless you specifically opt in. The image size increase isn’t due to these components in the standard release workflow. If you’re seeing them included despite this, it might be worth double-checking for any custom overrides in your build environment.
Sources:
- tag-release.yml workflow does not enable Chromium/Playwright
- Default Docker env disables Playwright/Chromium
- docker-compose.yml defaults INCLUDE_CHROMIUM to false
To reply, just mention @dosu.
How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other