Bug description
max_column_name_length is set to 30 in the OracleEngineSpec class. But since Oracle Version 12.2 the max field name length is 128. Oracle Versions prior to 12.2 have reached end-of-life long ago.
There is no direct configuration option or environment variable in Superset to override the max_column_name_length for Oracle, as far as I know.
Can we set the default max_column_name_length = 128 with the next Superset release?
The original Q&A: 33016
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Comment From: rusackas
@sumeet-singh04 has volunteered on the rolodex as an Oracle user - perhaps they have some feedback or ability to test here?
Comment From: rusackas
In general though, if this is supported by current versions of oracle, it sounds like a reasonable (and super simple) PR to me.
@dosu-bot what do you think?
Comment From: rusackas
Based on this, it seems we'd be fine:
Comment From: rusackas
@rluech happy to review a PR, but otherwise we'll close this as inactive. CC @msyavuz to see if this is a tactic we want to adopt. I still just don't have a way to test.
Comment From: msyavuz
This is a trivial change to make as you can see in this pr. However i am not sure how we can test this and if this is something we want to do. Maybe @betodealmeida might have an idea.
Comment From: betodealmeida
Yeah, I think it's reasonable to do this change.