After #46731, //go:notinheap is gone, however, there's still test/fixedbugs/notinheap.go which is using it. There's no problem with trybot, because the file is ignored:

https://github.com/golang/go/blob/34f0029a85af054787b279761e89db410621f1d7/test/run.go#L1975

We should revise those test cases:

  • Writing the equivalent ones, replacing //go:notinheap by cgo.Incomplete.
  • Remove the file entirely.

cc @mdempsky @randall77

Comment From: cuonglm

Taking a quick look, not all the cases can be rewrite, for example, there's no thing like this anymore:

//go:notinheap
type t3 byte

Comment From: gopherbot

Change https://go.dev/cl/597535 mentions this issue: cmd/compile: restore not-in-heap check for map/channel type

Comment From: gopherbot

Change https://go.dev/cl/597536 mentions this issue: test: re-enabled fixedbugs/notinheap.go test

Comment From: gopherbot

Change https://go.dev/cl/597537 mentions this issue: test: add test cases for local not-in-heap types