#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/filewatcher" && test == "TestStress"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestStress
panic: send on closed channel

goroutine 770 [running]:
golang.org/x/tools/gopls/internal/filewatcher.(*Watcher).watchDir.func1()
    /Users/swarming/.swarming/w/ir/x/w/targetrepo1844784717/gopls/internal/filewatcher/filewatcher.go:304 +0x25
golang.org/x/tools/gopls/internal/filewatcher.(*Watcher).watchDir(0xc00011e9a0, {0xc0000e4dc0, 0x46}, 0xc0002227e0, 0xc000069110)
    /Users/swarming/.swarming/w/ir/x/w/targetrepo1844784717/gopls/internal/filewatcher/filewatcher.go:314 +0x1f7
created by golang.org/x/tools/gopls/internal/filewatcher.(*Watcher).handleEvent in goroutine 16
    /Users/swarming/.swarming/w/ir/x/w/targetrepo1844784717/gopls/internal/filewatcher/filewatcher.go:233 +0x3a5

— watchflakes

Comment From: gopherbot

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/filewatcher" && test == "TestStress"
2025-07-29 18:02 x_tools-go1.24-darwin-amd64-longtest tools@3e9ce406 release-branch.go1.24@390ffce7 x/tools/gopls/internal/filewatcher.TestStress [SKIP] (log) === RUN TestStress panic: send on closed channel goroutine 770 [running]: golang.org/x/tools/gopls/internal/filewatcher.(*Watcher).watchDir.func1() /Users/swarming/.swarming/w/ir/x/w/targetrepo1844784717/gopls/internal/filewatcher/filewatcher.go:304 +0x25 golang.org/x/tools/gopls/internal/filewatcher.(*Watcher).watchDir(0xc00011e9a0, {0xc0000e4dc0, 0x46}, 0xc0002227e0, 0xc000069110) /Users/swarming/.swarming/w/ir/x/w/targetrepo1844784717/gopls/internal/filewatcher/filewatcher.go:314 +0x1f7 created by golang.org/x/tools/gopls/internal/filewatcher.(*Watcher).handleEvent in goroutine 16 /Users/swarming/.swarming/w/ir/x/w/targetrepo1844784717/gopls/internal/filewatcher/filewatcher.go:233 +0x3a5

— watchflakes

Comment From: gopherbot

Change https://go.dev/cl/691935 mentions this issue: gopls/internal/filewatcher: watcher wg guarding around watchDir call

Comment From: gopherbot

Change https://go.dev/cl/693096 mentions this issue: gopls/internal/filewatcher: fix race condition on watcher shutdown