Currently this code in ApiVersionConfigurer means that if you call setVersionRequired(true) but forget to call a use... method API versioning is disabled and the required version is not enforced.
Comment From: DhruvTheDev1
Hi - I will open a PR for this issue
- I am thinking of logging a warning such as API version is required but no version is configured and adding a default resolver .useRequestHeader("X-API-Version");
Comment From: philwebb
@DhruvTheDev1 I would wait for someone from the team to provide a direction. I suspect we'll want an exception instead of a warning.
Comment From: DhruvTheDev1
@philwebb Is throwing an exception better in this case? If versionRequired = true but no resolvers are added then it will immediately fail - hence it's impossible to overlook and ensures the developer fixes the problem. However for logging and falling to a default resolver is more of a safety net.
Comment From: philwebb
I don't know, that's why I'd suggest waiting before submitting a PR.