Screenshot
Example of inconsistent button order (primary on the left):
Example of consistent button order (primary on the right):
Description
There is an inconsistency in the placement of primary and secondary buttons on multiple pages within the Security section of the Settings.
On the Roles, Users, and Groups pages, the primary button appears on the left and the secondary on the right.
On the Row Level Security page (and in other pages like Themes and CSS Templates), the secondary button is on the left and the primary on the right, which seems to be the standard across the application.
If this inconsistency is not deliberate, I have a fix prepared and can open a PR to address it.
Comment From: dosubot[bot]
You’re right—there’s an inconsistency in the button order on the Roles, Users, and Groups pages, with the primary button on the left, while the standard elsewhere in Superset is primary on the right. This standard was reinforced in recent PRs that reordered buttons across CRUD/list pages to put the primary action rightmost, such as PR #34294 and PR #34389. The official Button Design Guidelines also support this pattern. There’s no evidence this inconsistency is deliberate, so a PR to align the Security section with the established standard would be welcome.
To reply, just mention @dosu.
How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other
Comment From: rusackas
CC @msyavuz @kasiazjc
Comment From: msyavuz
Nice catch again! Added the fix to the open pr