gomote create -list
has a hardcoded 5 second timeout https://cs.opensource.google/go/x/build/+/master:cmd/gomote/create.go;l=82 , that is only applied on gomote create -list
. If someone is new to gomote, or using gomote on a new machine, they needs to do login, and 5 seconds is too short for completing the login steps. And gomote create -list
is usually the first command one run.
Is there a reason for that very short timeout? I think we can increase it to, say, a minute. If there is actually an RPC timeout, it wouldn't be too bad if it fails in a minute.
Alternatively, if a gomote command sees the user is not logged in, it can exec gomote login
, and re-exec the gomote command again.
Comment From: cherrymui
cc @golang/release cc @dr2chase
Comment From: gopherbot
Change https://go.dev/cl/605317 mentions this issue: cmd/gomote: apply swarmingBuilders timeout only to the RPC