Screenshot

WHAT IS HAPPENING: Image Image EXPECTED:

Image Image

Description

The dataset column is giving weird displays of names if it's virtual and has a weird format. I think it's a mix of these 2 playing weird. Image Image

Comment From: dosubot[bot]

Hello @ethan-l-geotab! I'm Dosu, here to help you with bugs, questions, or anything you need while we wait for a human maintainer. Let’s tackle your issue together!

The issue you're experiencing with virtual datasets not displaying correctly in the chart list may be related to the format of the dataset names. The datasource_name_text method constructs the dataset name by checking for the presence of schema and table_name or name attributes. If these attributes are not formatted correctly, it could lead to unexpected displays [1].

Additionally, the React component configuration for the table column uses a custom cell rendering function that splits the dataset name by '.' and takes the second element. This could cause issues if the dataset name does not follow the expected format, leading to incorrect or incomplete display [2].

To resolve this, ensure that the dataset names are correctly formatted with the expected schema and table name or name attributes. This should help in displaying the dataset names properly in the chart list.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

Comment From: ethan-l-geotab

Maybe doing: /superset/models/slice.py Image Image

and then of course adding it to the charts api and the charts interface in chart.ts?

Comment From: rusackas

Is it just the 2.1.0 name causing issues? I guess it's that the dataset name has . characters in it causing the issue due to the split. That was added in https://github.com/apache/superset/pull/29944, so perhaps @eschutho knows any intricacies here that might need to be worked around.

Comment From: ethan-l-geotab

Dataset names without . will cause issues. so like "Jinja 5" just disappears.

It's probably only an issue with virtual datasets where they can be named anything

Comment From: rusackas

CC @mistercrunch / @sadpandajoe in case someone at Preset has run into this.