Inconsistent Text Color Theme Fallback 
Tell me more
###### What is the issue? The colorTextSecondary fallback to colorText may result in inconsistent text color behavior when themes are changed. ###### Why this matters If colorTextSecondary is undefined in some themes but defined in others, the text color will switch between two different color variables, potentially causing unexpected visual changes. ###### Suggested change ā *Feature Preview* Use only one theme color variable to ensure consistent behavior across themes:color: ${theme.colorText};
š¬ Looking for more details? Reply to this comment to chat with Korbit.
Originally posted by @korbit-ai[bot] in https://github.com/apache/superset/pull/35096#discussion_r2337718805
Comment From: dosubot[bot]
Hi @ismaelricopalasios-maker! I'm Dosu and Iām helping the superset team.
Superset's theming system expects all necessary tokens, like colorText and colorTextSecondary, to be defined in the active theme. There is no fallback logic (such as colorTextSecondary || colorText) implemented in the codebase, and components should not rely on such fallbacks. If a token is missing, the system either uses Ant Design's default or the value is simply absent. This design matches the recommendation to use a single theme color variable for consistent behavior across themes, as relying on fallbacks can cause the kind of visual inconsistencies you described when switching themes. Defining and using only one variable (like theme.colorText) is the intended and most robust approach for consistency across all themes1.
To reply, just mention @dosu.
How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report š | Other 
