Screenshot
light themes
dark themes
Description
CloseOutlined icons not visible in dark themes
Comment From: SBIN2010
I suspect the background property is missing in superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx CloseButton style.
background: linear-gradient(currentColor 0 0) 0 100%/0% 3px no-repeat;
Comment From: dosubot[bot]
You're correct—the CloseButton in ConditionalFormattingControl.tsx does not have a background property set. Its visibility in dark themes depends entirely on the background behind it, which can make the CloseOutlined icon hard to see or invisible in dark mode. Adding a background (such as the gradient you suggested) to the CloseButton would likely resolve the visibility issue and improve accessibility in dark themes. You can see the current style definition here for reference: source.
To reply, just mention @dosu.
How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other 
