We should create an AuthorizationManager that can lookup authorities using a configured SQL statement given the username of the currently authenticated user. If any values are returned, then it returns those authorities otherwise it grants access to the user.
Pseudo code looks like:
List<String> additionalAuthorities = findAdditionalAuthorities(authentication.get().getName()); // lookup from SQL statement
if (additionalAuthorities.isEmpty() {
return new AccessDecision(true);
}
else {
return AllAuthoritiesAuthorizationManager.hasAllAuthorities(additionalAuthorities).authorize(authentication, object);
}
NOTE: findAdditionalAuthorities should use a mapper object of sorts that can swap out. It can return some constants if the SQL returns true or it can lookup the additional authorities in SQL.
This can then be used for situations where it is a user preference to enable multi-factor authentication. We should also update the documentation to show how to use it. Something like this:
AuthorizationManager<Object> additionalAuthorization = SqlAllAuthoritiesAuthorizationManager
.whenTrue("select true from users where mfa_enabled = true and username = :username")
.additionalAuthorities("FACTOR_PASSWORD", "FACTOR_OTT")
.dataSource(dataSource)
.build()
return new DefaultAuthorizationManagerFactory.build()
.additionalAuthorization(additionalAuthorization)
.build();
an additional option for users that gets the authorities from SQL:
AuthorizationManager<Object> additionalAuthorization = SqlAllAuthoritiesAuthorizationManager
.selectAuthorities("select authorities from additional_authorities where username = :username")
.dataSource(dataSource)
.build()
return new DefaultAuthorizationManagerFactory.build()
.additionalAuthorization(additionalAuthorization)
.build();
Comment From: rwinch
NOTE: If you want this issue, know that it is fairly urgent (we want to get it in for RC1). Also please ensure to claim it (by commenting here) after validating that it has not been assigned or otherwise claimed (via a comment) by someone else before working on it.
Comment From: therepanic
Hi, @rwinch! Can I work on it? Also, could you please explain how long RC1 lasts and within what timeframe it should be completed?
Comment From: rwinch
@therepanic Thank you for volunteering. The issue is yours.
We will release 7.0.0-RC1 on Oct 20 so this will need to be in a PR form at least a week beforehand so we have time to review and work out any changes.