Bug description
When adding a filter, if add a pre filter, when select a time type field, the edit time range window should be displayed above the filter.
Screenshots/recordings
Superset version
master / latest-dev
Python version
3.11
Node version
I don't know
Browser
Chrome
Additional context
No response
Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Comment From: dosubot[bot]
This display issue is likely caused by the stacking context (z-index) of the time range window (popover or modal) relative to the filter modal. The filter modal uses Ant Design's Modal component, which defaults to a z-index around 1000–1001. The time range editing UI can render as either a popover or a modal: when rendered as a modal, it sets zIndex=1030, which should place it above the filter modal; when rendered as a popover, it attaches to document.body by default, but if not, its stacking can be affected by the parent modal and may appear underneath it.
If you are seeing the time range window hidden behind the filter modal, check whether the time range editor is rendering as a popover and whether its container is set to document.body. If not, or if the z-index is too low, this can cause the issue you described. Ensuring the time range window always renders to document.body and/or increasing its z-index should resolve the problem. The relevant code is in DateFilterLabel.tsx
for the time range window and FiltersConfigModal.tsx
for the filter modal. See more details in the code here:
DateFilterLabel.tsx
FiltersConfigModal.tsx
No recent changes or documentation directly address this, but adjusting the z-index or ensuring the popover/modal attaches to the correct container should fix the stacking issue.
To reply, just mention @dosu.
How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other
Comment From: msyavuz
Modal in modal strikes again! Thanks for reporting this, opened a pr to fix it.