CL 702376 introduced a new test TestMCPVulncheckCommand
which always fails on Plan 9, for example here:
--- FAIL: TestMCPVulncheckCommand (13.41s)
mcp_test.go:340: calling "initialize": EOF
FAIL
FAIL golang.org/x/tools/gopls/internal/cmd 491.900s
The error message "EOF" does not have a huge amount of diagnostic value, but the initialisation in this test follows the pattern of the other failing tests in mcp_test.go
reported in issue #74580, and therefore I believe the test should be skipped on platforms where fsnotify
is not supported.
Comment From: gabyhelp
Related Issues
- x/tools/gopls/internal/cmd: TestMCP* tests fail on Plan 9 #74580 (closed)
- x/tools/gopls/internal/cmd: TestMCPVulncheckCommand failures [consistent failure] #75445 (closed)
- cmd/go: TestGoEnv failing on Plan 9 #18013 (closed)
- os/exec: TestLookPath fails on plan9 after CL 685755 #74892 (closed)
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
Comment From: gopherbot
Change https://go.dev/cl/706695 mentions this issue: gopls/internal/cmd: skip TestMCPVulncheckCommand when fsnotify not supported