Background: gopls has an analyzer that inlines calls to functions annotated with //go:fix inline
directives. We would like to make this functionality available in go fix (see https://github.com/golang/go/issues/71859).
Proposal: we propose to move (and rename) the x/tools/gopls/internal/gofix directory to x/tools/go/analysis/passes/inline
package inline // import "golang.org/x/tools/go/passes/inline"
var Analyzer *analyzer.Analyzer
Comment From: gabyhelp
Related Issues
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)
Comment From: aclements
This proposal has been added to the active column of the proposals project and will now be reviewed at the weekly proposal review meetings. — aclements for the proposal review group
Comment From: aclements
Based on the discussion above, this proposal seems like a likely accept. — aclements for the proposal review group
The proposal details are given in https://github.com/golang/go/issues/75267#issue-3385340178
Comment From: aclements
No change in consensus, so accepted. 🎉 This issue now tracks the work of implementing the proposal. — aclements for the proposal review group
The proposal details are given in https://github.com/golang/go/issues/75267#issue-3385340178
Comment From: gopherbot
Change https://go.dev/cl/706899 mentions this issue: go/analysis/passes/inline: publish