Screenshot
Description
In 'table' chart, if Page Length
drop down is something other than All:
There is text that says Select page size
that is right in front of Show _ entries per page
. Seems like only one of these statements should be there, probably the one that allows you do make a selection.
https://github.com/apache/superset/blob/6.0.0rc2/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx#L221-L224
Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review
. If this includes a design proposal,
include the label design:suggest
]
Comment From: dosubot[bot]
This UI issue happens because the code in TableChart.tsx renders both a visually hidden label ("Select page size") for accessibility and the visible text ("Show _ entries per page") together, without any conditional logic to avoid redundancy. The hidden label is meant for screen readers, but both appear in the DOM, which can look confusing in some contexts. There are currently no design guidelines in Superset documentation that address this specific case. For design review, it would make sense to either remove or conditionally display one of these texts to improve clarity and avoid duplication in the pagination controls. You can see the relevant code and logic here.
To reply, just mention @dosu.
How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other
Comment From: sadpandajoe
@saraburns1 you can see if your issues are addressed with https://github.com/apache/superset/pull/35648. There should be an ephemeral that is being spun up.
Comment From: saraburns1
Perfect - thank you!