Bug description
- Go to a dashboard or Explore view in Superset with a table visualization connected to Impala.
- Click on the dropdown to change the number of rows displayed (e.g., from 50 to 100).
- See error: The table still displays the number of rows originally set in the chart configuration (e.g., 50), even though the pagination updates correctly, and exporting to CSV downloads the expected number of records (e.g., 100). The SQL query also reflects the correct number of rows, but the table visualization does not update accordingly.
Note: The issue only occurs when increasing the row limit beyond the default configuration. Reducing the number of rows appears to work as expected.
This is the default page size. I have 178 pages.
If I change to ALL, the table just display the original 200. And the pagination is ok.
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Comment From: dosubot[bot]
A similar issue has been reported where table chart pagination was not working correctly since version 4.1.0. The suggested solution was to check if the 'server pagination' option is enabled and ensure that the 'server page length' is set appropriately. This setting is crucial for pagination to work correctly, and adjusting it to a higher value might resolve the issue [1].
Additionally, in Superset version 4.1.1, there were several changes related to table visualization and pagination, including fixes for backend pagination and improvements to sorting and column width calculation [2]. It might be worth reviewing these changes to see if they impact your current setup.
To continue talking to Dosu, mention @dosu.
Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other
Comment From: paulobitar
A similar issue has been reported where table chart pagination was not working correctly since version 4.1.0. The suggested solution was to check if the 'server pagination' option is enabled and ensure that the 'server page length' is set appropriately. This setting is crucial for pagination to work correctly, and adjusting it to a higher value might resolve the issue [1].
Additionally, in Superset version 4.1.1, there were several changes related to table visualization and pagination, including fixes for backend pagination and improvements to sorting and column width calculation [2]. It might be worth reviewing these changes to see if they impact your current setup.
To continue talking to Dosu, mention @dosu.
Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other
@dosu The option server pagination is enabled. The problem happens with any value that I set to page size and always happens when the user Increases tha page size on the dashboard. I also inpected the chrome console and I saw that the data is being returned by the backend. So the problem is something in the frontend
Comment From: rusackas
Possible duplicate of https://github.com/apache/superset/issues/31626?
Comment From: dosubot[bot]
Could you provide more details about any custom configurations or extensions you might be using in your Superset setup? Additionally, are there any specific errors or warnings in the browser's developer console that might give more insight into the issue?
To continue talking to Dosu, mention @dosu.
Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other
Comment From: paulobitar
Possible duplicate of #31626?
Yes. Sorrry, you area right. It's the same issue.
Comment From: paulobitar
Could you provide more details about any custom configurations or extensions you might be using in your Superset setup? Additionally, are there any specific errors or warnings in the browser's developer console that might give more insight into the issue?
To continue talking to Dosu, mention @dosu.
Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other
@dosu There are no custom configurations in our Superset setup, apart from the organization's LDAP authentication and the fact that we are running Superset with two workers.
I have attached a screenshot of the issue along with the browser's developer console output for further insights. Let me know if any additional details are needed.
Comment From: dosubot[bot]
It seems like the issue you're experiencing with the table visualization not updating the row limit is related to how the frontend handles pagination. Since the server pagination is enabled and the backend is returning the correct data, the problem might be in the frontend processing.
Here are a few things to consider:
-
CORS Policy: The blocked stylesheet request due to CORS policy might not directly affect the table data, but ensure that all resources are correctly loaded to avoid unexpected behavior in the frontend.
-
Frontend Pagination Handling: Superset's frontend uses the
useTable
hook andPagination
component to manage pagination. Make sure theserverPagination
andserver_page_length
settings are correctly configured. ThepageCount
andgotoPage
functions should handle page changes properly [1]. -
Console Errors: Check for any JavaScript errors or warnings in the console that might indicate issues with rendering or updating the table component.
-
Superset Version: Ensure you are using the latest patches for version 4.1.1, as there have been several fixes related to pagination and table rendering [2].
Additionally, I found a similar issue that might be helpful: Table chart pagination is not working since version 4.1.0. The suggested solution is to check if the 'server pagination' option is enabled and ensure that the 'server page length' is set appropriately, as this setting is crucial for pagination to work correctly.
If these steps don't resolve the issue, consider reviewing the frontend code related to table rendering and pagination to ensure it's correctly processing the data returned from the backend.
To continue talking to Dosu, mention @dosu.
Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other
Comment From: paulobitar
@rusackas can you tell if is there any prevision to fix this bug ?
Comment From: rusackas
There's sadly no fix for it yet. We're open to investigations/PRs here. It does seem problematic indeed.
I'll close this as a duplicate of https://github.com/apache/superset/issues/31626, and hopefully we can get some further help there.
Comment From: rusackas
Actually, can you test on master
with the merged fix for the linked (duplicate?) issue in place? I know I just closed this, but confirmation it's resolved would be nice :)