#!stacks
"bug.Errorf" &&
(/* item.Path == mp.PkgPath */
"importPackage.func1:+14" ||
"importPackage.func1:+15" ||
"importPackage.func1:+18" ||
/* item.Path != mp.PkgPath */
"importPackage.func1:+40" ||
/* pkg.Name() == "" */
"importPackage.func1:+49")
This stack 5MRL7A
, _ZM1lw
was reported by telemetry:
cache.(*typeCheckBatch).importPackage.func1:19 is
// debugging issue #60904
if pkg.Name() != item.Name {
return bug.Errorf("internal error: package name is %q, want %q (id=%q, path=%q) (see issue #60904)",
pkg.Name(), item.Name, id, item.Path)
}
The related issue #63822 appears to have the same root cause: there are duplicate package paths in the export data manifest; see https://github.com/golang/go/issues/63822#issuecomment-2289843179.
This stack PXUK4g
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.16.1 go1.23.0 darwin/arm64 neovim (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.6 linux/amd64 other,vscode (2)
golang.org/x/tools/gopls@v0.16.1 go1.22.0 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.3 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.23.0 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.6 darwin/arm64 vscode (2)
golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.5 darwin/arm64 neovim (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.5 linux/amd64 vscode (2)
golang.org/x/tools/gopls@v0.16.1 go1.20.8 darwin/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.4 darwin/arm64 other,vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.0 darwin/arm64 neovim,other (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.6 darwin/arm64 other,vscode (1)
golang.org/x/tools/gopls@v0.16.2-pre.1 go1.22.6 darwin/amd64 other (1)
golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.2-pre.2 go1.21.7 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.20.7 linux/amd64 vscode (2)
golang.org/x/tools/gopls@v0.16.1 go1.22.0 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.21.7 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.5 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.23.0 darwin/arm64 vscode (6)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).importPackage.func1:19
golang.org/x/tools/internal/gcimporter.iimportCommon:116
golang.org/x/tools/internal/gcimporter.IImportShallow:3
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).importPackage:41
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).getImportPackage:55
golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).awaitPredecessors.func1:1
golang.org/x/sync/errgroup.(*Group).Go.func1:3
runtime.goexit:0
golang.org/x/tools/gopls@v0.14.1 go1.21.3 linux/amd64 (2)
golang.org/x/tools/gopls@v0.14.1 go1.19.1 darwin/amd64 (1)
Reported using golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
This stack aiQRfw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:35
golang.org/x/tools/gopls/internal/util/bug.Errorf:2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:14
golang.org/x/tools/internal/gcimporter.iimportCommon:123
golang.org/x/tools/internal/gcimporter.IImportShallow:3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:55
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:1
golang.org/x/sync/errgroup.(*Group).Go.func1:3
runtime.goexit:0
golang.org/x/tools/gopls@v0.15.0-pre.2 go1.22rc2 linux/amd64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Dups: ebxaEQ 2vh0nQ
This stack KVl6Kg
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+123
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+55
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.15.0 go1.22.0 darwin/arm64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Dups: Ar_rPw 33irXg PXUK4g ptgmiQ j64HJw FjuvhQ rlqkaQ
Dups without stacks (too numerous): T YioIw Dups: 8lUnNg nHnxwA C0oOoQ orz9eg LWE90w b-ZEYg lz1QUA JtyMWA JITKgg MP8B4Q n5Nrkw vIomOQ HfwAjw URzRLA HvwCZQ KkBf4g uZo-JQ 8cMKWw
Comment From: findleyr
Would love to see the error message for this one.
Comment From: findleyr
Since we added this bug report specifically because we couldn't figure it out, I don't think we're going to make easy progress without the content.
I'm not sure what to do about this, but it's not going to get resolved for v0.15.0.
Comment From: adonovan
The 15.0-pre2 stack I just appended to the original node implicates this statement:
// debugging issues #60904, #64235
if pkg.Name() != item.Name {
// This would mean that mp.Name != item.Name, so the
// manifest in the export data of mp.PkgPath is
// inconsistent with mp.Name. Or perhaps there
// are duplicate PkgPath items in the manifest?
return bug.Errorf("internal error: package name is %q, want %q (id=%q, path=%q) (see issue #60904)",
pkg.Name(), item.Name, id, item.Path)
}
Comment From: adonovan
This stack 2vh0nQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+123
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+55
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls@v0.15.0-pre.3 go1.22.0 darwin/arm64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack ebxaEQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+123
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+55
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.15.0-pre.3 go1.22.0 darwin/arm64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack Ar_rPw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+123
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+55
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls@v0.15.1 go1.21.0 windows/amd64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack 33irXg
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+123
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+55
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=304
golang.org/x/tools/gopls@v0.15.3 go1.20.3 linux/amd64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack PXUK4g
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.16.0-pre.1 go1.22.4 darwin/arm64 vscode-insiders (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack ptgmiQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.16.0 go1.22.3 linux/amd64 vscode (2)
golang.org/x/tools/gopls@v0.16.1 go1.22.4 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.21.7 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.0 go1.20.8 darwin/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.0 go1.21.3 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.0 go1.21.11 linux/amd64 vscode (1)
golang.org/x/tools/gopls@v0.16.0 go1.22.4 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.1 go1.22.3 linux/amd64 vscode (5)
golang.org/x/tools/gopls@v0.16.1 go1.22.4 darwin/arm64 vscode (1)
golang.org/x/tools/gopls@v0.16.0 go1.22.2 linux/amd64 other,vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack j64HJw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls@v0.16.1 go1.21.9 linux/amd64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack FjuvhQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls@v0.16.1 go1.22.2 darwin/arm64 vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack rlqkaQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+44
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+32
go/types.(*Checker).Files:=341
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).checkPackageForImport:+50
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+51
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+20
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/gopls@v0.16.1 go1.21.3 darwin/arm64 other (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack TYioIw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+44
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.16.1 go1.22.3 darwin/arm64 other,vscode (1)
Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Comment From: adonovan
This stack nHnxwA
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+26
go/types.(*Checker).Files:+13
golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)
Comment From: adonovan
This stack C0oOoQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+20
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackageInternal.func1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.16.1 go1.22.6 darwin/arm64 vscode (1)
Comment From: gopherbot
Change https://go.dev/cl/621858 mentions this issue: gopls/internal/cache: refine a bug report related to package metadata
Comment From: adonovan
This stack orz9eg
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+20
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).handleSyntaxPackage.func2:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)
Comment From: adonovan
According to the tty output of the stacks command, we had nearly 200 reports of these stacks this week alone. A lot!
Comment From: adonovan
This stack LWE90w
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+18
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1.1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.17.0-pre.1 go1.23.2 darwin/arm64 vscode (2)
golang.org/x/tools/gopls@v0.17.0-pre.2 go1.23.3 darwin/arm64 vscode (1)
Comment From: adonovan
The stack above is not the GOPACKAGESDRIVER case, interestingly.
Comment From: adonovan
This stack b-ZEYg
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+20
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+20
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls@v0.16.2 go1.22.7 linux/amd64 vscode (1)
Comment From: adonovan
This stack lz1QUA
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+18
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+33
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
golang.org/x/tools/gopls@v0.17.0-pre.3 go1.23.3 linux/amd64 vscode (1)
Comment From: adonovan
This stack JtyMWA
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+18
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+26
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls@v0.17.1 go1.23.3 linux/amd64 vscode (1)
Comment From: adonovan
This stack JITKgg
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+15
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1.1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.17.1 go1.23.4 linux/amd64 vscode (1)
Comment From: gopherbot
Change https://go.dev/cl/643778 mentions this issue: gopls/internal/cache: add more debugging for golang/go#64235
Comment From: adonovan
This stack MP8B4Q
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1.1:=517
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+49
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1.1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.18.0-pre.1 go1.23.6 windows/amd64 vscode (1)
golang.org/x/tools/gopls@v0.18.0-pre.1 go1.23.6 linux/amd64 vscode (2)
golang.org/x/tools/gopls@v0.18.0-pre.1 go1.23.4 linux/amd64 other,vscode (1)
This stack n5Nrkw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+40
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+33
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
go/types.(*Checker).collectObjects:+42
golang.org/x/tools/gopls@v0.17.1 go1.23.4 darwin/arm64 vscode (1)
Comment From: adonovan
The recent stack MP8B4Q is from a refinement indicating that pkg.Name() == ""
.
Comment From: adonovan
This stack vIomOQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+18
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+63
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+33
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=384
go/types.(*Checker).collectObjects:+45
golang.org/x/tools/gopls@v0.17.1 go1.24.0 darwin/arm64 vscode (1)
Comment From: adonovan
This stack HfwAjw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1.1:=517
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+49
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+33
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=391
golang.org/x/tools/gopls@v0.18.0-pre.3 go1.23.6 windows/amd64 other (1)
Comment From: findleyr
This failure mode is possible if:
1. go/packages reports no Name
2. the package has files with a valid package
clause.
Because then go/types will set the package name from the file. https://cs.opensource.google/go/go/+/master:src/go/types/check.go;l=342;drc=676d427f77ea255fa6e4cdebf0fb348a27575855
Unfortunately, I can't reproduce this: I can get go/packages to list packages with CompiledGoFiles and no name, but only if all the files in the package have a missing or broken package
clause, in which case go/types
also won't find a name.
So, this looks like another case where the gopls logic clearly makes an assumption that it should not (the input package name is the same as the output package name), but we can't figure out how that invalid assumption is exercised.
Comment From: adonovan
This stack URzRLA
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1.1:=517
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+49
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+82
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls@v0.18.0 go1.23.6 darwin/arm64 other (1)
Comment From: adonovan
This stack HvwCZQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1.1:=517
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+49
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+33
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+31
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=384
golang.org/x/tools/gopls@v0.18.1 go1.24.0 linux/amd64 vscode (2)
Comment From: adonovan
This stack KkBf4g
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+15
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1.1:+1
golang.org/x/sync/errgroup.(*Group).Go.func1:+3
runtime.goexit:+0
golang.org/x/tools/gopls@v0.18.1 go1.23.6 linux/amd64 vscode (1)
Comment From: adonovan
This stack uZo-JQ
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+14
golang.org/x/tools/internal/gcimporter.iimportCommon:+124
golang.org/x/tools/internal/gcimporter.IImportShallow:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+57
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+56
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).typesConfig.func1:+20
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+10
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=383
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+18
go/types.(*Checker).Files:=307
golang.org/x/tools/gopls@v0.16.2 go1.19.1 darwin/arm64 other (1)
Comment From: adonovan
This stack 8cMKWw
was reported by telemetry:
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35,+0x393
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2,+0x3b
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1.1:=497,+0xa6f
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage.func1:+49,+0xa70
golang.org/x/tools/internal/gcimporter.iimportCommon:+124,+0x787
golang.org/x/tools/internal/gcimporter.IImportShallow:+3,+0x37
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).importPackage:+119,+0x2eb
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage.func1:+23,+0x1b7
golang.org/x/tools/gopls/internal/cache.(*futureCache[...]).get:+32,+0x35f
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getImportPackage:+1,+0x5f
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1.1:+1,+0x4f
golang.org/x/sync/errgroup.(*Group).add.func1:+32,+0x87
runtime.goexit:+0,+0x3
golang.org/x/tools/gopls@v0.19.0-pre.2 go1.24.3 darwin/arm64 vscode (2)
golang.org/x/tools/gopls@v0.19.0-pre.1 go1.24.3 darwin/arm64 other (1)
golang.org/x/tools/gopls@v0.19.0-pre.2 go1.24.3 darwin/arm64 other (1)