#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestCreateModule_Interdependent/default"
Issue created automatically to collect these failures.
Example (log):
=== RUN TestCreateModule_Interdependent/default
workspace_test.go:458: expected modb/b/b.go, got /Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/gopath/pkg/mod/b.com@v1.2.3/b/b.go
#### Start Gopls Test Logs for "TestCreateModule_Interdependent/default"
[Trace - 08:08:24.285 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/work","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":[""]}},"dataSupport":true,"resolveSupport":{"properties":["edit"]}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary","interface","struct","signature","pointer","array","map","slice","chan","string","number","bool","invalid"],"formats":null}},"window":{"workDoneProgress":true,"showDocument":{"support":true}}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/gopath","GOPROXY":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/proxy","GOSUMDB":"off","GOTOOLCHAIN":"local"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/work","name":"work"}]}
[Trace - 08:08:24.289 AM] Received response 'initialize - (1)' in 3ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["gopls.doc.features","quickfix","refactor.extract.constant","refactor.extract.constant-all","refactor.extract.function","refactor.extract.method","refactor.extract.toNewFile","refactor.extract.variable","refactor.extract.variable-all","refactor.inline.call","refactor.rewrite.changeQuote","refactor.rewrite.fillStruct","refactor.rewrite.fillSwitch","refactor.rewrite.invertIf","refactor.rewrite.joinLines","refactor.rewrite.removeUnusedParam","refactor.rewrite.splitLines","source.assembly","source.doc","source.fixAll","source.freesymbols","source.organizeImports"],"resolveProvider":true},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.add_test","gopls.apply_fix","gopls.assembly","gopls.change_signature","gopls.check_upgrades","gopls.client_open_url","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.extract_to_new_file","gopls.fetch_vulncheck_result","gopls.free_symbols","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.modify_tags","gopls.modules","gopls.package_symbols","gopls.packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.scan_imports","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.tidy","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.vulncheck","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","typeParameter","parameter","variable","function","method","macro","keyword","comment","string","number","operator","label"],"tokenModifiers":["definition","readonly","defaultLibrary","array","bool","chan","format","interface","map","number","pointer","signature","slice","string","struct"]},"range":true,"full":true},"typeHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{"didCreate":{"filters":[{"scheme":"file","pattern":{"glob":"**/*.go"}}]}}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.24.3-devel_34c8b14ca9f4096383d658fbd748322a993a2bd2\",\"Path\":\"golang.org/x/tools/gopls/internal/test/integration/workspace.test\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"(devel)\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":[{\"Key\":\"-buildmode\",\"Value\":\"exe\"},{\"Key\":\"-compiler\",\"Value\":\"gc\"},{\"Key\":\"CGO_ENABLED\",\"Value\":\"1\"},{\"Key\":\"CGO_CFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CPPFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CXXFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_LDFLAGS\",\"Value\":\"\"},{\"Key\":\"GOARCH\",\"Value\":\"arm64\"},{\"Key\":\"GOOS\",\"Value\":\"darwin\"},{\"Key\":\"GOARM64\",\"Value\":\"v8.0\"}],\"Version\":\"(devel)\"}"}}
...
[Trace - 08:08:24.515 AM] Sending request 'textDocument/definition - (3)'.
Params: {"textDocument":{"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/work/moda/a/a.go"},"position":{"line":8,"character":7}}
[Trace - 08:08:24.515 AM] Received response 'textDocument/definition - (3)' in 0ms.
Result: null
#### End Gopls Test Logs for "TestCreateModule_Interdependent/default"
--- FAIL: TestCreateModule_Interdependent/default (0.28s)
Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/workspace" && test == "TestCreateModule_Interdependent/default"
2025-05-09 15:03 x_tools-go1.24-darwin-arm64_15 tools@8ee3f58c release-branch.go1.24@34c8b14c x/tools/gopls/internal/test/integration/workspace.TestCreateModule_Interdependent/default (log)
=== RUN TestCreateModule_Interdependent/default workspace_test.go:458: expected modb/b/b.go, got /Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/gopath/pkg/mod/b.com@v1.2.3/b/b.go #### Start Gopls Test Logs for "TestCreateModule_Interdependent/default" [Trace - 08:08:24.285 AM] Sending request 'initialize - (1)'. Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/work","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":[""]}},"dataSupport":true,"resolveSupport":{"properties":["edit"]}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary","interface","struct","signature","pointer","array","map","slice","chan","string","number","bool","invalid"],"formats":null}},"window":{"workDoneProgress":true,"showDocument":{"support":true}}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/gopath","GOPROXY":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/proxy","GOSUMDB":"off","GOTOOLCHAIN":"local"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/work","name":"work"}]} [Trace - 08:08:24.289 AM] Received response 'initialize - (1)' in 3ms. Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["gopls.doc.features","quickfix","refactor.extract.constant","refactor.extract.constant-all","refactor.extract.function","refactor.extract.method","refactor.extract.toNewFile","refactor.extract.variable","refactor.extract.variable-all","refactor.inline.call","refactor.rewrite.changeQuote","refactor.rewrite.fillStruct","refactor.rewrite.fillSwitch","refactor.rewrite.invertIf","refactor.rewrite.joinLines","refactor.rewrite.removeUnusedParam","refactor.rewrite.splitLines","source.assembly","source.doc","source.fixAll","source.freesymbols","source.organizeImports"],"resolveProvider":true},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.add_test","gopls.apply_fix","gopls.assembly","gopls.change_signature","gopls.check_upgrades","gopls.client_open_url","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.extract_to_new_file","gopls.fetch_vulncheck_result","gopls.free_symbols","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.modify_tags","gopls.modules","gopls.package_symbols","gopls.packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.scan_imports","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.tidy","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.vulncheck","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","typeParameter","parameter","variable","function","method","macro","keyword","comment","string","number","operator","label"],"tokenModifiers":["definition","readonly","defaultLibrary","array","bool","chan","format","interface","map","number","pointer","signature","slice","string","struct"]},"range":true,"full":true},"typeHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{"didCreate":{"filters":[{"scheme":"file","pattern":{"glob":"**/*.go"}}]}}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.24.3-devel_34c8b14ca9f4096383d658fbd748322a993a2bd2\",\"Path\":\"golang.org/x/tools/gopls/internal/test/integration/workspace.test\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"(devel)\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":[{\"Key\":\"-buildmode\",\"Value\":\"exe\"},{\"Key\":\"-compiler\",\"Value\":\"gc\"},{\"Key\":\"CGO_ENABLED\",\"Value\":\"1\"},{\"Key\":\"CGO_CFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CPPFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CXXFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_LDFLAGS\",\"Value\":\"\"},{\"Key\":\"GOARCH\",\"Value\":\"arm64\"},{\"Key\":\"GOOS\",\"Value\":\"darwin\"},{\"Key\":\"GOARM64\",\"Value\":\"v8.0\"}],\"Version\":\"(devel)\"}"}} ... [Trace - 08:08:24.515 AM] Sending request 'textDocument/definition - (3)'. Params: {"textDocument":{"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-3219634240/TestCreateModule_Interdependent/default/work/moda/a/a.go"},"position":{"line":8,"character":7}} [Trace - 08:08:24.515 AM] Received response 'textDocument/definition - (3)' in 0ms. Result: null #### End Gopls Test Logs for "TestCreateModule_Interdependent/default" --- FAIL: TestCreateModule_Interdependent/default (0.28s)Comment From: adonovan
This failure indicates that, after a go.work file was added, the location of package modb/b did not change as it should have (which is the primary purpose of the test); the stale location was returned. The test failed exactly once, on darwin/arm64.
Comment From: findleyr
Unfortunately, I don't think we'll be able to investigate a long flake. Moving to backlog.