#!watchflakes
default <- pkg == "unique" && test == "TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys"
Issue created automatically to collect these failures.
Example (log):
=== RUN TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys
canonmap_test.go:121: expected key 1000-13 to be missing from map, got 0x8826d68
canonmap_test.go:121: expected key 1001-13 to be missing from map, got 0x8826d78
canonmap_test.go:121: expected key 1010-13 to be missing from map, got 0x8826d88
canonmap_test.go:121: expected key 1011-13 to be missing from map, got 0x8826d98
canonmap_test.go:121: expected key 1100-13 to be missing from map, got 0x8826da8
canonmap_test.go:121: expected key 1101-13 to be missing from map, got 0x8826db8
canonmap_test.go:121: expected key 1110-13 to be missing from map, got 0x8826dc8
canonmap_test.go:121: expected key 1111-13 to be missing from map, got 0x8826dd8
canonmap_test.go:121: expected key 10000-13 to be missing from map, got 0x8826de8
canonmap_test.go:121: expected key 10001-13 to be missing from map, got 0x8826df8
canonmap_test.go:121: expected key 10010-13 to be missing from map, got 0x8826e08
canonmap_test.go:121: expected key 10011-13 to be missing from map, got 0x8826e18
canonmap_test.go:121: expected key 10100-13 to be missing from map, got 0x8826e28
canonmap_test.go:121: expected key 10101-13 to be missing from map, got 0x8826e38
canonmap_test.go:121: expected key 10110-13 to be missing from map, got 0x8826e48
canonmap_test.go:121: expected key 10111-13 to be missing from map, got 0x8826e58
canonmap_test.go:121: expected key 11000-13 to be missing from map, got 0x8826e68
canonmap_test.go:121: expected key 11001-13 to be missing from map, got 0x8826e78
canonmap_test.go:121: expected key 11010-13 to be missing from map, got 0x8826e88
canonmap_test.go:121: expected key 11011-13 to be missing from map, got 0x8826e98
canonmap_test.go:121: expected key 11100-13 to be missing from map, got 0x8826ea8
canonmap_test.go:121: expected key 11101-13 to be missing from map, got 0x8826eb8
canonmap_test.go:121: expected key 11110-13 to be missing from map, got 0x8826ec8
canonmap_test.go:121: expected key 11111-13 to be missing from map, got 0x8826ed8
--- FAIL: TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (0.12s)
Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "unique" && test == "TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys"
2025-06-09 18:15 gotip-linux-386 go@985d600f unique.TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (log)
=== RUN TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys canonmap_test.go:121: expected key 1000-13 to be missing from map, got 0x8826d68 canonmap_test.go:121: expected key 1001-13 to be missing from map, got 0x8826d78 canonmap_test.go:121: expected key 1010-13 to be missing from map, got 0x8826d88 canonmap_test.go:121: expected key 1011-13 to be missing from map, got 0x8826d98 canonmap_test.go:121: expected key 1100-13 to be missing from map, got 0x8826da8 canonmap_test.go:121: expected key 1101-13 to be missing from map, got 0x8826db8 canonmap_test.go:121: expected key 1110-13 to be missing from map, got 0x8826dc8 canonmap_test.go:121: expected key 1111-13 to be missing from map, got 0x8826dd8 canonmap_test.go:121: expected key 10000-13 to be missing from map, got 0x8826de8 canonmap_test.go:121: expected key 10001-13 to be missing from map, got 0x8826df8 canonmap_test.go:121: expected key 10010-13 to be missing from map, got 0x8826e08 canonmap_test.go:121: expected key 10011-13 to be missing from map, got 0x8826e18 canonmap_test.go:121: expected key 10100-13 to be missing from map, got 0x8826e28 canonmap_test.go:121: expected key 10101-13 to be missing from map, got 0x8826e38 canonmap_test.go:121: expected key 10110-13 to be missing from map, got 0x8826e48 canonmap_test.go:121: expected key 10111-13 to be missing from map, got 0x8826e58 canonmap_test.go:121: expected key 11000-13 to be missing from map, got 0x8826e68 canonmap_test.go:121: expected key 11001-13 to be missing from map, got 0x8826e78 canonmap_test.go:121: expected key 11010-13 to be missing from map, got 0x8826e88 canonmap_test.go:121: expected key 11011-13 to be missing from map, got 0x8826e98 canonmap_test.go:121: expected key 11100-13 to be missing from map, got 0x8826ea8 canonmap_test.go:121: expected key 11101-13 to be missing from map, got 0x8826eb8 canonmap_test.go:121: expected key 11110-13 to be missing from map, got 0x8826ec8 canonmap_test.go:121: expected key 11111-13 to be missing from map, got 0x8826ed8 --- FAIL: TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (0.12s)Comment From: manishkandari9
This issue may be caused by a race condition during concurrent access. Since the keys are unshared, LoadOrStore is expected to safely handle them in parallel. However, the presence of unexpected keys in the map suggests that synchronization may not be working as intended.
Running the test with the -race flag might help detect data races. It may also be worth reviewing how CanonMap handles internal state for unique keys during concurrent operations, to identify any potential flaws in synchronization logic.
Comment From: mknyszek
Possibly, but I think this is more likely due to improperly waiting for cleanup functions to execute, which are what actually remove the entries from the map. The map implementation this is based on (and closely follows) is quite solid, and doesn't have similar failures.
Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "unique" && test == "TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys"
2025-06-27 15:23 go1.25-darwin-amd64_12 release-branch.go1.25@fdc076ce unique.TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (log)
=== RUN TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys canonmap_test.go:121: expected key 0-3 to be missing from map, got 0xc000024a90 canonmap_test.go:121: expected key 1-3 to be missing from map, got 0xc000244000 canonmap_test.go:121: expected key 11010-3 to be missing from map, got 0xc0002800c0 canonmap_test.go:121: expected key 11011-3 to be missing from map, got 0xc0002800d0 canonmap_test.go:121: expected key 11100-3 to be missing from map, got 0xc0002441c0 canonmap_test.go:121: expected key 11101-3 to be missing from map, got 0xc0002441d0 canonmap_test.go:121: expected key 101011-3 to be missing from map, got 0xc000244510 canonmap_test.go:121: expected key 101100-3 to be missing from map, got 0xc000244520 canonmap_test.go:121: expected key 101111-3 to be missing from map, got 0xc000244550 canonmap_test.go:121: expected key 110000-3 to be missing from map, got 0xc000244560 canonmap_test.go:121: expected key 110001-3 to be missing from map, got 0xc000244570 canonmap_test.go:121: expected key 110010-3 to be missing from map, got 0xc000244580 canonmap_test.go:121: expected key 110011-3 to be missing from map, got 0xc0002445a0 canonmap_test.go:121: expected key 110100-3 to be missing from map, got 0xc0001fe590 canonmap_test.go:121: expected key 110101-3 to be missing from map, got 0xc0001fe5a0 canonmap_test.go:121: expected key 110110-3 to be missing from map, got 0xc0001fe5b0 canonmap_test.go:121: expected key 110111-3 to be missing from map, got 0xc0001fe5c0 canonmap_test.go:121: expected key 111000-3 to be missing from map, got 0xc0001fe5d0 canonmap_test.go:121: expected key 111001-3 to be missing from map, got 0xc0001fe5e0 canonmap_test.go:121: expected key 111010-3 to be missing from map, got 0xc0001fe5f0 canonmap_test.go:121: expected key 111011-3 to be missing from map, got 0xc0001fe600 canonmap_test.go:121: expected key 111100-3 to be missing from map, got 0xc0001fe610 canonmap_test.go:121: expected key 111101-3 to be missing from map, got 0xc0001fe620 canonmap_test.go:121: expected key 111110-3 to be missing from map, got 0xc0001fe630 canonmap_test.go:121: expected key 111111-3 to be missing from map, got 0xc0001fe640 --- FAIL: TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (0.03s)Comment From: gopherbot
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "unique" && test == "TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys"
2025-07-24 16:59 gotip-darwin-amd64_12 go@44d73dfb unique.TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (log)
=== RUN TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys canonmap_test.go:121: expected key 1000-1 to be missing from map, got 0xc0000e6040 canonmap_test.go:121: expected key 1001-1 to be missing from map, got 0xc0000e6050 canonmap_test.go:121: expected key 1010-1 to be missing from map, got 0xc0000e6060 canonmap_test.go:121: expected key 1011-1 to be missing from map, got 0xc0000e6070 canonmap_test.go:121: expected key 1100-1 to be missing from map, got 0xc0000e6080 canonmap_test.go:121: expected key 1101-1 to be missing from map, got 0xc0000e6090 canonmap_test.go:121: expected key 1110-1 to be missing from map, got 0xc0000e60a0 canonmap_test.go:121: expected key 1111-1 to be missing from map, got 0xc0000e60b0 canonmap_test.go:121: expected key 10000-1 to be missing from map, got 0xc0000e60c0 canonmap_test.go:121: expected key 10001-1 to be missing from map, got 0xc0000e60d0 canonmap_test.go:121: expected key 10010-1 to be missing from map, got 0xc0000e60e0 canonmap_test.go:121: expected key 10011-1 to be missing from map, got 0xc0000e60f0 canonmap_test.go:121: expected key 10100-1 to be missing from map, got 0xc0000e6100 canonmap_test.go:121: expected key 10101-1 to be missing from map, got 0xc0000e6110 canonmap_test.go:121: expected key 10110-1 to be missing from map, got 0xc0000e6120 canonmap_test.go:121: expected key 10111-1 to be missing from map, got 0xc0000e6130 canonmap_test.go:121: expected key 11000-1 to be missing from map, got 0xc0000e6140 canonmap_test.go:121: expected key 11001-1 to be missing from map, got 0xc0000e6150 canonmap_test.go:121: expected key 11010-1 to be missing from map, got 0xc0000e6160 canonmap_test.go:121: expected key 11011-1 to be missing from map, got 0xc0000e6170 canonmap_test.go:121: expected key 11100-1 to be missing from map, got 0xc0000e6180 canonmap_test.go:121: expected key 11101-1 to be missing from map, got 0xc0000e6190 --- FAIL: TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys (0.03s)Comment From: gopherbot
Change https://go.dev/cl/697341 mentions this issue: unique: deflake TestCanonMap/LoadOrStore/ConcurrentUnsharedKeys