Bug description
Importing a dataset/chart/dashboard linked to a Trino database with TRINO_EXPAND_ROWS=True and "Row expansion in schema" activated, returns an error via the API & Superset interface.
To avoid this error, you need to remove the following lines from the YAML file before importing:
schema_options:
expand_rows: true
Superset API shouldn't break when new extras are added to a database as the database itself isn't altered when we remove existing extras from the YAML file and import the dataset with this altered schema. It seems like the extra in the YAML doesn't really matter at the end, so it shouldn't break the API.
Thx!
How to reproduce the bug
- Add the feature flag "TRINO_EXPAND_ROWS": True
- Enable "Row expansion in schema" on a Trino database
- Export a dataset as a zip using this database via the interface
- Import again this dataset (the same zip file)
- After validating, instead of proposing to overwrite your dataset, it will return an error
Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.10
Node version
16
Browser
Firefox
Additional context
No response
Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Comment From: rusackas
Is this still an issue in 4.x (or 5.0 RCs)? Was tempted to close this as stale, but nervous about doing so :)
Comment From: JustGui
I still have the same issue on 5.0.0rc1
Comment From: JustGui
But we could close this one as it's the same issue as https://github.com/apache/superset/issues/27027#issuecomment-2686791496
Comment From: rusackas
Thanks... closing in favor of #27027
Comment From: rusackas
Actually, if anyone can try on master and see if https://github.com/apache/superset/pull/32657 fixed this, it would be appreciated.